Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marked chat replied to as being noticed #3298

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

r10s
Copy link
Member

@r10s r10s commented Sep 17, 2024

when replying from within a notification,
the corresponding chat should be marked as being noticed as well.

otherwise, it looks wrong that one has replied to a chat, but still the chat is shown as being "unread".

the 'reply' from a notification should leave the chat in the same state as 'dismiss' resp. 'mark read' - plus the added message.

when replying from within a notification,
the corresponding chat should be marked as being noticed as well.

otherwise, it looks wrong that one has replied to a chat,
but still the chat is shown as being "unread".

the 'reply' from a notification should leave the chat
in the same state as 'dismiss' resp. 'mark read' - plus the added message.
@r10s r10s added the bug label Sep 17, 2024
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check the code besides the surrounding 10 lines, but the idea makes sense.

@r10s r10s merged commit 5f2b459 into main Sep 17, 2024
2 checks passed
@r10s r10s deleted the r10s/mark-replied-chat-noticed branch September 17, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants